search

virtio-win / virtio-win-guest-tools-installer

113 stars 19 forks source link

Bug 1976799: Remove ovirt guest agent windows #20

Closed Gal-Zaidman closed 3 years ago

Gal-Zaidman commented 3 years ago

On RHV 4.4 we depricated SSO to windows VMs[1]. Which means we can remove the ovirt guest agent windows from the installer since this is the only reason it is available

[1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html/release_notes/deprecated_features_rhv

Gal-Zaidman commented 3 years ago

Please do not merge before we tested and CI is passing

vrozenfe commented 3 years ago

Thanks a lot Gal.

Checked both msi and bundler on Win10 21H1 32/64-bit systems. Worked fine for all cases.

Best, Vadim.

ovirt-infra commented 3 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.