search

virtio-win / virtio-win-guest-tools-installer

113 stars 19 forks source link

VirtIO-FS Service's `Name` and `DisplayName` seem inverted #23

Closed jwatt closed 2 years ago

jwatt commented 2 years ago

https://github.com/virtio-win/virtio-win-guest-tools-installer/blob/9add9b4403310b079646973f57cd1839998d0229/virtio-win-drivers-installer/Drivers/viofs/viofs_extras.wxi#L25-L27

Opening the Windows Services app and looking at other Windows services (particularly MS Windows own services, but also the QEMU Guest Agent and Spice Agent services) it seems like the values for Name and DisplayName in the file above are inverted. Would a pull request to switch their values around be accepted?

jwatt commented 2 years ago

Most services also seem to have helpful descriptions. How about also changing the description to:

"Enables Windows virtual machines to access directories on the host that have been shared with it using VirtIO-FS."

YanVugenfirer commented 2 years ago

@jwatt thank you for your comment. Please send PR and let’s have discussion as part of the PR.

Please didn’t forget to have “Signed-off-by:” in the commit message.