search

virtio-win / virtio-win-guest-tools-installer

113 stars 19 forks source link

Change virtiofs service Name and DisplayName #24

Closed jwatt closed 2 years ago

jwatt commented 2 years ago

Fixes #23

Previously we were essentially doing:

sc create "Virtio FS Service" ... DisplayName=VirtioFsSvc

but now we're essentially doing:

sc create VirtioFsSvc ... DisplayName="Virtio FS Service"

The previous behavior was confusing because it made all future interacting with the service (using tools such as sc) look like the service's DisplayName was being specified where the command actually expects (requires!) the service's Name to be specified.

Note that this commit uses "VirtioFsSvc" as the service Name instead of "VirtioFSService". That's for consistency with the instructions that people have been using when following:

https://virtio-fs.gitlab.io/howto-windows.html

This commit also adds a "Description" field to help people determine what the service is for when they encounter it in the Services app, for example.

Signed-off-by: Jonathan Watt jwatt@jwatt.org

ovirt-infra commented 2 years ago

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project. As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.