search

virtio-win / virtio-win-guest-tools-installer

121 stars 19 forks source link

Releases seem not to contain the SPICE drivers #25

Open ljrk0 opened 2 years ago

ljrk0 commented 2 years ago

The SPICE vdagent from https://www.spice-space.org/download.html seems not to be part of any MSI or ISO image built. Neither seems the SPICE driver be part of the distribution, although I'm unclear what is meant by that. AFAIK the vdagent only depends on the some virtio drivers.

vrozenfe commented 2 years ago

@ljrk0 Even though that vda agent needs virtio-serial, SPICE is a completely separate project with its own work-flow. We do have SPICE vda agent and qxl-dod drivers MSIs embedded into the bundler (virtio-win-guest-tools.exe) located in the root of virtio-win iso image.

Regards, Vadim.

ljrk0 commented 2 years ago

Hi @vrozenfe , thank you for your response!

I think I'm mostly confused about whether SPICE is included or not with respect to this note in the README:

Virtio-win guest tools installer is a msi (Microsoft installer) created with Wix Toolset which installs:

Spice guest agent and driver - Spice is an open remote computing solution, providing client access to remote machine display and devices, more info on the Offical website.

I've only run the virtio-win-gt-x64.msi as I thought that this is part/executed by virtio-win-guest-tools.exe and as far as I can tell, virtio-win-gt-x64.msi does not contain the SPICE vdagent (and neither QXL DoD?). However, if these are part of the virtio-win-guest-tools.exe then everything is fine.

I think what I'm missing is mostly this:

Suppose I have a Windows VM and want to install everything to support extended QEMU (qemu-agent), virtio, QXL and SPICE. I'm left a bit confused what I'm supposed to install, according to the documentation.

  1. The virtio-win-iso contains virtio-win-gt-....msi files which seem to install virtio drivers only.
  2. The virtio-win-guest-tools.exe seems to contain virtio drivers as cabinet files next to qxl, qemu and spice(?), I suppose?
  3. Next to these executables are the drivers in "raw form" as .inf to be loaded e.g., during an installation of the VM.

The README of this project also links to spice-space.org which has its own downloads:

  1. spice-guest-tools which contains spice vdagent, QXL and vioserial (however horribly out of date, as it seems)
  2. And SPICE WebDAV

Of course you are not responsible for the SPICE project, but since the README links to the page as well as claims that some part of SPICE is included in this installer, it might be helpful to clear this up better. I'd be glad to volunteer writing the updated documentation, as soon as I myself understand what parts are packaged where :)

Cheers!

Remzi1993 commented 2 years ago

@ljrk0 You only need to download the: Windows guest tools - spice-guest-tools under Guest

See: https://www.ctrl.blog/entry/how-to-win10-in-gnome-boxes.html for explaination and instructions.

ljrk0 commented 1 year ago

@ljrk0 You only need to download the: Windows guest tools - spice-guest-tools under Guest

See: https://www.ctrl.blog/entry/how-to-win10-in-gnome-boxes.html for explaination and instructions.

Thanks for the reply, however I've already tried this download but these downloads seem to be out of date:

The README of this project also links to spice-space.org which has its own downloads:

  1. spice-guest-tools which contains spice vdagent, QXL and vioserial (however horribly out of date, as it seems) And SPICE WebDAV
ljrk0 commented 1 year ago

To be more precise, as you can see here, the downloads are from 2018:

https://www.spice-space.org/download/windows/spice-guest-tools/

ljrk0 commented 1 year ago

Yep, the release is 0.141 which is horribly out of date, c.f.: https://gitlab.freedesktop.org/spice/win32/spice-nsis/-/issues/17

ljrk0 commented 1 year ago

I did some more research, and while I couldn't find the vdagent in the MSI when extracting it, the installation does definitely contain the vd-agent etc. -- as is described in the Makefile.

@vrozenfe: I think part of the confusion is that the documentation is distributed over spice-space.org, the README of this repo, and the README of the https://github.com/virtio-win/virtio-win-pkg-scripts repo. I propose having one place (this or the virtio-win-pkg-scripts repo) have a proper list of components such as:

Components

Ideally with some information what version they pull from where. The other repository simply links the repository containing that information.

Similarly this part of the README:

The installer is distributed as part of virtio-win package on Fedora.

Is duplicated here as well: https://github.com/virtio-win/virtio-win-pkg-scripts#downloads

FWIW, for the current release, I found the following versions:

which can be followed from here: https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/virtio-win-pkg-scripts-input/virtio-win-0.1.221-1/

However, it's yet unclear where the QEMU GA binaries come from (and in general, that this contains the GA at all seems undocumented?).

After the documentation has been straightened out, one could ping the people over at SPICE that they maybe simply link to this installer instead as it covers everything the SPICE installer does as well.

vrozenfe commented 1 year ago

@ljrk0 Fully agree. The README files need to be updated in synchronised between all virtio-win related projects. We will sort it out. Regarding the origin of QEMU GA binaries - they are coming from our internal build system mostly because the same QEMU guest agent binaries are used for building both upstream and downstream (production) virtio-win rpms.

Best, Vadim.

YanVugenfirer commented 1 year ago

@ljrk0 Starting from RHEL9.0 timeline the binaries of qemu-ga-mingw are originating from the CentOS (and then RHEL) RPMs.

CentOS RPM content can be tracked here: https://gitlab.com/redhat/centos-stream/rpms/mingw-qemu-ga-win

Best regards, Yan.

vrrc commented 6 months ago

This still happens with newer relases of the installer. Neither 0.1.248 or 0.1.240 install spice vdagent on Windows 10 or 11. Spice agent is needed in the guest OS for QEMU's "clipboard=vnc" parameter allows copy/paste using noVNC console on Proxmox VE.

vrozenfe commented 6 months ago

Spice agent is not a part of RHEL virtio-win package anymore. This is the reason why it was removed from the upstream distribution as well, since we are trying to keep the upstream virtio-win package as close to the RHEL virtio-win package as possible. Honestly, I don't want to add spice and qxl-dod MSIs back to the bundle. But I can make them a part of ISO and RPM to let the user to install them manually.

Best, Vadim.

vrrc commented 5 months ago

Problem is that when upgrading using the ISO from a previous version like 0.1.229 to 0.1.248, the spice agent is removed and the new version has no mention about that the agent isn't installed anymore. IMHO it would be very helpful to both include a message in the installer informing that spice agent is not installed automatically and include the installer in the ISO so it can be easily installed if needed. Somewhat related to this, there's no mention about this in the changelog. Maybe there's some other more deailed changelog that I'm missing? Thanks!

rgl commented 4 months ago

FWIW, this is also being mentioned in https://github.com/virtio-win/virtio-win-pkg-scripts/issues/76#issuecomment-2103185076.

rgl commented 1 month ago

can you please confirm that the spice agent, removed in https://github.com/virtio-win/virtio-win-guest-tools-installer/commit/926dbaca56b03507ecdb6c624e3bb95204f6904a, was re-introduced in https://github.com/virtio-win/virtio-win-pkg-scripts/commit/62c74d124bac4bf8422bf54a97a10702a8f5b938 and included in https://fedorapeople.org/groups/virt/virtio-win/direct-downloads/archive-virtio/virtio-win-0.1.262-2/? if so, maybe this issue can be closed?

vrozenfe commented 1 month ago

@rgl

Confirmed.

Vadim.