CORE-895 Fix overlapping select items with another select

virtru / react-components

Virtru standard React components for daily use

Other

1 stars 3 forks source link

CORE-895 Fix overlapping select items with another select #66

Closed kuguarpwnz closed 4 years ago

kuguarpwnz commented 4 years ago

Proposed Changes

Before:

After:

Checklist

Place an x inside the brackets to check off items.

[x] I have updated the change log
[x] I have updated storybook as needed
[x] I have updated VRT baselines and included diff images above in "Proposed Changes"
[x] I have incremented the package.json and package-lock.json version number

svirtryu commented 4 years ago

There's a failing VRT, can you take a look? It's for Select in mobile

kuguarpwnz commented 4 years ago

There's a failing VRT, can you take a look? It's for Select in mobile

This happens when the reference screenshot doesn't have a blinking cursor on it, but the pipeline screenshot has. (and vice versa) We should handle this case somehow 🤔

svirtryu commented 4 years ago

@kuguarpwnz is there a way to remove the focus from the textarea so the cursor does not show?

kuguarpwnz commented 4 years ago

@kuguarpwnz is there a way to remove the focus from the textarea so the cursor does not show?

some tests are made to test focus state...

svirtryu commented 4 years ago

@kuguarpwnz yeah, maybe we can find a way around it. Anyway for now this PR looks good.