CORE-899 Remove display: inline-block from Link

virtru / react-components

Virtru standard React components for daily use

Other

1 stars 3 forks source link

Closed kuguarpwnz closed 4 years ago

kuguarpwnz commented 4 years ago

Remove display: inline-block; for Link component to prevent line break issues like this (dot is placed on the new line after "Terms of Service" link):

Place an x inside the brackets to check off items.

[x] I have updated the change log
[ ] I have updated storybook as needed
[ ] I have updated VRT baselines and included diff images above in "Proposed Changes"
[x] I have incremented the package.json and package-lock.json version number

kuguarpwnz commented 4 years ago

It's potential breaking change. Should we bump to v1.0.0?

svirtryu commented 4 years ago

It's potential breaking change. Should we bump to v1.0.0?

We don't have to worry about breaking changes in versions under 1.0 anyways, semver should handle this without issues. It's also noted in the README.