search

virtual-kubelet / node-cli

CLI library for rapid prototyping of virtual-kubelet nodes
Apache License 2.0
18 stars 30 forks source link

Make stream timeouts configurable #19

Closed ldx closed 4 years ago

ldx commented 4 years ago

virtual-kubelet/virtual-kubelet@0bdf7423037e0ccefb794c8b5f570137c65ce864 in virtual-kubelet made exec timeout configurable. However, node-cli has not got updated since to configure a default timeout, so any exec operation will fail right away now if node-cli is used for wiring up a provider to virtual-kubelet.

I added the same default timeouts here that the kubelet uses for consistency.

cpuguy83 commented 4 years ago

This PR is fine, but we need to fix vk/vk because that's a breaking change.

cpuguy83 commented 4 years ago

https://github.com/virtual-kubelet/virtual-kubelet/pull/833