search

virtual-kubelet / node-cli

CLI library for rapid prototyping of virtual-kubelet nodes
Apache License 2.0
18 stars 30 forks source link

feat: wait for node controller started #30

Closed LeoLiuYan closed 3 years ago

LeoLiuYan commented 4 years ago

cc @cpuguy83

cpuguy83 commented 4 years ago

Still, this should go in your own code, not at the library level.

LeoLiuYan commented 4 years ago

Still, this should go in your own code, not at the library level.

First, controller's ready function not expose to who ues the node-cli library. And notify to systemd also should be handle in the node-cli just like kube-apiserver or kube-scheduer do.

LeoLiuYan commented 4 years ago

// Wait for node controller ready <-nodeRunner.Ready()

I also think we should wait for controller ready after https://github.com/virtual-kubelet/node-cli/blob/master/internal/commands/root/root.go#L231.

cpuguy83 commented 4 years ago

We can add a Ready function.

feiskyer commented 3 years ago

Close since there's no activity for more than 5 months. Feel free to open a new PR if you think the changes are still required.