Closed LeoLiuYan closed 3 years ago
Still, this should go in your own code, not at the library level.
Still, this should go in your own code, not at the library level.
First, controller's ready function not expose to who ues the node-cli library. And notify to systemd also should be handle in the node-cli just like kube-apiserver or kube-scheduer do.
// Wait for node controller ready <-nodeRunner.Ready()
I also think we should wait for controller ready after https://github.com/virtual-kubelet/node-cli/blob/master/internal/commands/root/root.go#L231.
We can add a Ready
function.
Close since there's no activity for more than 5 months. Feel free to open a new PR if you think the changes are still required.
cc @cpuguy83