fix panic: client is nil when EnableNodeLease is false

virtual-kubelet / node-cli

CLI library for rapid prototyping of virtual-kubelet nodes

Apache License 2.0

18 stars 30 forks source link

fix panic: client is nil when EnableNodeLease is false #41

Closed chaolou closed 2 years ago

chaolou commented 3 years ago

node-cli need to disable node lease (enabel-node-lease=false) when kubernetes vesison <= v1.13, but it will always trigger panic in WithNodeEnableLeaseV1WithRenewInterval function of virtual-kubelet framework.

cpuguy83 commented 2 years ago

I don't know why CI didn't run on this. Can you squash commits and push?

chaolou commented 2 years ago

I have rebased and pushed again, now it's only one commit left.