search

virtual-labs-archive / computer-programming-responsive-iiith

This repository contains the responsive Computer Programming Lab IIITH
https://cse02-iiith.vlabs.ac.in
Other
1 stars 325 forks source link

computer-programminglab_all-experiments: Unmaintainable and unextensible PHP files #435

Open GaurangTandon opened 5 years ago

GaurangTandon commented 5 years ago

The PHP files are unmaintainable and severely NOT DRY. Can be refactored into a for loop.

GaurangTandon commented 5 years ago

Fixed via:

https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/438/commits/14c0c87d63b2053aafb9dbafd6705c034e33ad33

https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/440/commits/d9eee3554496cc69796fc07aa4fcc2865cf993d8

https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/439/commits/e4f9810cade8007825ac812aad905e575048935e

https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/436/commits/c352cf5331c278781f9e77d11be1372a6017812b

https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/437/commits/4e7d6915015a838a63ef70760a33ff1951728e5d

Issue is still not over yet, as five more experiments remain. I'll let someone else take up the remaining.

KanishAnand commented 5 years ago

issue fixed for exp1 commit id :https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/443/commits/2dfccebfc7929c2cde2d3ecac6f7ad3300687f85

KanishAnand commented 5 years ago

change of variable names(exp1) commit id : https://github.com/virtual-labs/computer-programming-responsive-iiith/pull/443/commits/00d661c0bd9f2ff72d2322061c3e2228b19d5172

Manish17292000 commented 5 years ago

Issue fixed for exp2 commit id : da93f19d951ac58d80c6c9f826c84fae6e8e682a

Manish17292000 commented 5 years ago

Issue fixed for exp3 commmit id : 33e4ffaf8bfdfa231e0aa7a05d85b7ef8f8b6d4f

Manish17292000 commented 5 years ago

Issue fixed for exp4 commit id : b605ab138f127a32997b7fac20ac3dae4bfb8f87

Manish17292000 commented 5 years ago

Minor change in a variable value (exp4) commit id b5a2a7cda160b45cd7c141d06f33e29e23cf3393

destinyson7 commented 5 years ago

Fixed for exp5. Commit id: 7e8b23af20b63c86403cf40aef9cd3b63eed3cd3

DevikaBoddu commented 5 years ago

Valid fix: @Manish17292000 @destinyson7

GaurangTandon commented 5 years ago

@DevikaBoddu I also fixed five of the total ten experiments. Please see the second comment in this PR.