search

virtual-labs-archive / hydraulics-and-fluid-mechanics-iiith-ph2

Other
1 stars 245 forks source link

Hydraulics-and-Fluid-mechanics-iiith_Venturimeter_Experiment #53

Open kurasaiteja opened 6 years ago

kurasaiteja commented 6 years ago

Defect Description: As any user such as iPhone/iPad users cannot access experiment simulations which are in the .swf format, we need to to change .swf to HTML 5 and Javascript which is universal and anyone can use.

Steps to reproduce the issue:

Go to the IIIT Hyderabad section in the vlabs main website. Click on Hydraulics and fluid mechanics. Go to the experiments section. Go to the Venturimeter experiment. Click on the link which redirects us to a flash file. Expected Result: Any user could be able to view the simulation irrespective of the device which they are using.

Actual result: Some users couldn't see the simulation since their handsets do not support .swf files

kurasaiteja commented 6 years ago

commit id: 359c93a(added html file) 4afbdcb(changed dimensions), 2e3be44 (added js file) 708e22a(changed description)

aakarsh7599 commented 6 years ago

@kurasaiteja , Change in the link description is suggested. (Remove go to flash view in experiment.html)

kurasaiteja commented 6 years ago

@aakarsh7599 check it out

aakarsh7599 commented 6 years ago

Valid fix

adityagoda24 commented 6 years ago

Valid Fix

Shubhada-Kapre commented 6 years ago

Converted .swf to html My commit ID: 70d67b0

Uppala-Kalanandini commented 6 years ago

valid fix @Shubhada-Kapre