virtual-labs-archive / physical-chemistry-iiith

Other
1 stars 64 forks source link

physical-chemistry-(iiith)-lab_nuclear-magnetic-resosnace-spectrocopy-and-evaulation-of-simple-1h-nmr-spectra-of-select-organic-compounds_experiment #19

Open gayatripurigilla opened 6 years ago

gayatripurigilla commented 6 years ago

Defect description : when clicked on the 'click here' option in the experiment it is popping up a message down at the bottom that the type of file is harmful to the computer.steps to reproduce issue:1.click on physical chemistry lab.2.select list of experiments.3.click on the experiment nuclear magnetic resosnace spectrocopy and evaulation of simple 1h nmr spectra of select organic compounds.4.select experiment .5.click on 'click here' option .expected result : the experiment should not cause any harm to the computer.actual result : a pop message that the type of file is harmful is displayed at the bottom.environment : os-windows 8.1 hardware configuration: 8 gb ram processor :i5 browser : google chromeattachments:image

SaiKrishnaReddy644 commented 6 years ago

fixed it f30a666

VishwanathamSarika commented 6 years ago

The same pop up is coming , i think the issue is not fixed yet

image1

SaiKrishnaReddy644 commented 6 years ago

Ok I will see about it

On Thu 21 Jun, 2018, 1:24 PM VishwanathamSarika, notifications@github.com wrote:

The same pop up is coming , i think the issue is not fixed yet

[image: image1] https://user-images.githubusercontent.com/39979596/41705299-37c97b50-7556-11e8-8eff-86eb29e84cdf.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/virtual-labs/physical-chemistry-iiith/issues/19#issuecomment-399010191, or mute the thread https://github.com/notifications/unsubscribe-auth/AYhBzWgBg4ATak0QswsmcVeOAIPpJhhLks5t-1EWgaJpZM4Ujzyu .

SaiKrishnaReddy644 commented 6 years ago

fix id f408924ac16c9a80d1966a05580baec32795f9b4

VishwanathamSarika commented 6 years ago

The issue is fixed now .

varshareddykumbham commented 6 years ago

Valid fix

Uppala-Kalanandini commented 6 years ago

COMMIT ID: 88b2b56 0274fab

Gowthambhujam commented 6 years ago

Valid fix @Uppala-Kalanandini