virtual-labs-archive / physical-chemistry-iiith

Other
1 stars 64 forks source link

Trailing whitespace #44

Open BSravanthi opened 5 years ago

BSravanthi commented 5 years ago

The [PEP 8: Programming Recommendations] (http://legacy.python.org/dev/peps/pep-0008/#programming-recommendations) mentions trailing whitespaces on a line only in context of split strings:

Don't write string literals that rely on significant trailing whitespace. Such trailing whitespace is visually indistinguishable and some editors will trim them.

Please refer to the following link to fix similar issues. https://app.codacy.com/app/BSravanthi/physical-chemistry-iiith/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W251bGxdfSx7ImlkIjoiQ2F0ZWdvcnkiLCJ2YWx1ZXMiOlsiQ29kZSBTdHlsZSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltudWxsXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOlsxNjNdfSx7ImlkIjoiQXV0aG9yIiwidmFsdWVzIjpbbnVsbF19LHsidmFsdWVzIjpbXX1d

somashekhar31 commented 5 years ago

commit id:https://github.com/virtual-labs/physical-chemistry-iiith/pull/60/commits/09886af04700c7672869e975feb56519472da684 (all experiments)

snehitharangu commented 5 years ago

Valid fix @somashekhar31

Khwaja-Bilkhis commented 5 years ago

in this file : src/lab/exp6_10/scraplab.py the trailing space is not removed i guess(line 67) image

somashekhar31 commented 5 years ago

in this file : src/lab/exp6_10/scraplab.py the trailing space is not removed i guess(line 67) image

@Khwaja-Bilkhis you can refer this textfile proa.txt the changes are made accordingly!!

Khwaja-Bilkhis commented 5 years ago

validated-2 fixed @somashekhar31