virtual-labs-archive / quantum-chemistry-iiith

Other
1 stars 29 forks source link

quantum-chemistry-lab_geometry-optimization-using-ab-initio-quantum-calculations_quizzes #72

Open gayatripurigilla opened 6 years ago

gayatripurigilla commented 6 years ago

Defect description :in the given quiz consider a case of we not attempting a question.after we click on submit option the unattempted question is also shown as wrong which is not right.to prevent this an instruction to attempt all questions must be given beforehand or the unattempted question must not be graded at all. **steps to reproduce the issue:* open the virtual labs link "http://vlab.co.in" click on iiit hyderabad under the participating institutes option present on left side of your page. click on hyperlink of quantum chemistry lab. click on list of experiments and geometry optimization using ab initio quantum calculations . click on quizzes option. expected result: unattempted answer to be not graded. actual result: unattempted answer is displayed as wrong. screenshots:** 131

aakarsh7599 commented 6 years ago

Fixed the issue. Commit ID: 31680cc610e389dfc0bdac5eb2f6577d7f1329be

kurasaiteja commented 6 years ago

Valid fix

adityagoda24 commented 6 years ago

valid fix

fireballpoint1 commented 6 years ago

Invalid fix, add a message that says all questions need to be answered. Required option works. S3

aakarsh7599 commented 6 years ago

The problem here is it is allowing us to submit even if we don’t mark some answers. I fixed it by asking the user to attempt every question

fireballpoint1 commented 6 years ago

@aakarsh7599 as quoted in the fix "to prevent this an instruction to attempt all questions must be given beforehand", your fix works otherwise. Add the message

aakarsh7599 commented 6 years ago

@fireballpoint1 Check this out! Commit ID: 861010b65dcfa61bf87e68cc7afef66849770aa0, b1ddebcde5e2cc4fdaa7dec532dca8c98c83aac8

fireballpoint1 commented 6 years ago

@aakarsh7599 get it validated by someone else first

kurasaiteja commented 6 years ago

Valid fix @aakarsh7599

Rashmi-G commented 6 years ago

valid fix @aakarsh7599

fireballpoint1 commented 6 years ago

Fix is validated and can be moved to production, @aakarsh7599 S4