virtual-labs-archive / quantum-chemistry-iiith

Other
1 stars 29 forks source link

Quantum-Chemistry_UV-Visible-Spectroscopy-of-Conjugated-Systems_Quizzes #79

Closed kurasaiteja closed 6 years ago

kurasaiteja commented 6 years ago

*Defect description :in the given quiz consider a case of we not attempting a question.after we click on submit option the unattempted question is also shown as wrong which is not right.to prevent this an instruction to attempt all questions must be given beforehand or the unattempted question must not be graded at all. steps to reproduce the issue: open the virtual labs link "http://vlab.co.in" click on iiit hyderabad under the participating institutes option present on left side of your page. click on hyperlink of quantum chemistry lab. click on list of experiments and any experiment . click on quizzes option. expected result: unattempted answer to be not graded. actual result: unattempted answer is displayed as wrong. screenshots:

capture

kurasaiteja commented 6 years ago

commit id is: a68c36e There is only one results file for all quizzes in this experiment.My fix ensures 1)only the attempted questions will be evaluated(ALL unattempted questions are ungraded because attempting all questions isnt mandatory always.Instead we can leave them ungraded) 2)An alert pops up when no questions are attempted

aakarsh7599 commented 6 years ago

Valid fix

kurasaiteja commented 6 years ago

@fireballpoint1 Please check this out

fireballpoint1 commented 6 years ago

Fix is validated and can be moved to production, krusaiteja , S3