virtual-labs / structural-dynamics-iiith-ph2

Other
0 stars 74 forks source link

Expected { after 'if' condition. (curly) #253

Open BSravanthi opened 6 years ago

BSravanthi commented 6 years ago

JavaScript allows the omission of curly braces when a block contains only one statement. However, it is considered by many to be best practice to never omit curly braces around blocks, even when they are optional, because it can lead to bugs and reduces code clarity. So the following:

//Bad
if (foo) foo++;

Can be rewritten as:

//Good
if (foo) {
    foo++;
}

Please refer to the following link to fix similar issues. https://app.codacy.com/app/BSravanthi/structural-dynamics-iiith/issues?&filters=W3siaWQiOiJMYW5ndWFnZSIsInZhbHVlcyI6W251bGxdfSx7ImlkIjoiQ2F0ZWdvcnkiLCJ2YWx1ZXMiOlsiQ29kZSBTdHlsZSJdfSx7ImlkIjoiTGV2ZWwiLCJ2YWx1ZXMiOltudWxsXX0seyJpZCI6IlBhdHRlcm4iLCJ2YWx1ZXMiOlsxNjYyXX0seyJ2YWx1ZXMiOltdfV0=

AksharaMayreddy commented 6 years ago

commit id's : 91d189468b6d5ebb53771a47eb9a288b5952643e ae02ba73a453ca903baecc1c9e31ce5805a0eaee fd9fbcf61bafd556ff3bfbc969d8a12b48cff703 e28d1a85b9f76ad860b259965288da079c4d3661 56fc2ee4a19630ee4c3423e3180b39f02f4e64b2 c8dbb3469a02c73babb7a59af83a937dfecda564 e333340d7a450fdb586bca704ffd65eb5fdb6210 35dbef22fd8d67dd290a88156d643998e8166c44 ad462d581f28510dd96aa0091f2d3ef6f012566d d05c97bc69322a1244cb4eae1151cb8e694915a3

niveditareddy commented 6 years ago

Issue fix@AksharaMayreddy

DevikaBoddu commented 6 years ago

Valid fix :@AksharaMayreddy