virtual-labs / svc-rating

https://virtual-labs.github.io/svc-rating/
GNU Affero General Public License v3.0
0 stars 0 forks source link

Multiple issues with rating not displayed on vlead page #10

Open shraddha opened 1 week ago

shraddha commented 1 week ago

On the page https://virtual-labs.github.io/app-vlead-web/, when you click on Learning Sphere -> Electronics and Comm. Engineering Labs, the rating of various labs is shown like below : vlead-rating-multiple-issues

This rating is picked up from this spreadsheet But there are multiple issues :

  1. Only a few labs are showing their proper rating. Most of the other labs appear to be Unrated - which is not true, as per the above spreadsheet.
  2. In the Unrated labs, there are a few labs who keep their source code on their Git server. e.g. https://dld-iitb.vlabs.ac.in/ or http://dldg-iitb.vlabs.ac.in/
  3. In the Unrated labs, there are a few labs which have a certain rating in the spreadsheet but it does not reflect on this page. e.g. https://he-coep.vlabs.ac.in/ (here, the lab_display_name is different than lab)
  4. In the rated labs, there are a few labs whose rating is picked up properly by the vlead code, so it shows up properly in the vlead popup, but when you go to the lab, on that page, the rating is not shown. (This part can be merged with https://github.com/virtual-labs/ph3-lab-mgmt/issues/522)
  5. Need to sort out all these labs. There are 4 categories (above). Need to figure out which category they fall into.
shraddha commented 1 week ago

Thanks to the detailed discussion with Priya, this is the update about the above issues:

Points 1 and 2 are relevant to each other and all the labs that are shown as Unrated, fall into either of the following category -

  1. The old UI for the labs are not ported into the new UI.
  2. The source code of the lab is hosted on their own Git server. Hence these lab cannot utilize the newer facilities like ratings. It also means point 5 above becomes invalid.

Point 3 and 4 are valid issues, and they will be taken care of through the issue already filed - https://github.com/virtual-labs/ph3-lab-mgmt/issues/522 Here we fix the display_lab_name to lab