virtual-puppet-project / vpuppr

VTuber application made with Godot 4
Mozilla Public License 2.0
735 stars 61 forks source link

Completely update godot-vrm addon to latest version #20

Closed you-win closed 2 years ago

you-win commented 3 years ago

The majority of the godot-vrm addon code is actually the code from ~January 2021 and there have been significant updates since then. The application is actually currently able to run off of Godot's 3.x branch but loading .vrm files is broken because of the outdated addon.

After chatting with the V-Sekai team, it looks like my modifications to the addon were unnecessary, so it should be possible to use the godot-vrm addon as a git submodule.

you-win commented 3 years ago

still waiting on merge from upstream godot-vrm repo

fire commented 3 years ago

What things are requested?

you-win commented 3 years ago

In order to use godot-vrm as a git submodule, the changes from this pr are required.

fire commented 2 years ago

Let's update this issue.

you-win commented 2 years ago

The issue is still technically blocked since the pr hasn't been merged yet + I have several other changes on my local version to work around Resource files losing data after being created (i.e. Resource files from godot-vrm have been changed to Reference and have the duplicate() function manually implemented.

If the pr will never be merged, then both the pr and this issue can be closed

you-win commented 2 years ago

Closing this issue for now, my fork of godot-vrm has diverged fairly heavily. Might open a new issue if a Godot 4 port of openseeface-gd comes around.