0az
commented
4 years ago Thanks for looking through all of these! Here's some notes based on a quick skim of that list:
-
feat-discord-oauth: not strictly needed (Jackson implemented it separately), but I'd like to revisit the code for other stuff at some point.
-
improve-download-behavior: delete
-
fix-mime-database: I believe Jackson did a separate fix? Might be worth looking at.
-
flyctl: We moved off of it a while back.
On Aug 23, 2020, at 10:38, Ryan Mast notifications@github.com wrote:
The option to automatically delete branches after a PR is merged helps a lot with keeping the number of old branches down. If for some reason there is a desire to keep a branch around after merging, it can either be set as a protected branch (e.g. develop), or it is easy to click the restore branch button on the PR after merging to restore the branch and keep it around for a while longer.
The setting is Automatically delete head branches on https://github.com/virtual-vgo/vvgo/settings#merge-button-settings
Going through https://github.com/virtual-vgo/vvgo/branches/all, all of the branches with the purple Merged icon should be safe to delete as a first pass.
@0az @jacksonargo @Ranzha I've marked the closed and never merged branches with some names below for who seems to have been working on the branch and could be the most relevant for deciding if it is still needed.
The ones marked Closed will require deciding if they will ever be relevant again. I looked through them and there were comments on some of them with things like "not needed".
• facebook-login #186 - abstraction was merged in another PR, need to decide if it is worth keeping around this branch [jacksonargo] • read-from-csv #165 - comment saying not needed [jacksonargo] • docker-compose-back #120 - a very similar file is already in master [jacksonargo] • login-controller #119 [jacksonargo] • codecov2 #107 - seems like codecov isn't really wanted at this time [jacksonargo] • storage-refactor #100 - comment saying it will be covered by #94, which was closed without merge (appears to have been split up into several smaller PRs) [jacksonargo] • sessions #94 - comment saying it can be closed without merge [jacksonargo] • logging-to-discord #88 - labelled as a draft [jacksonargo] • windows-weirdness #83 [jacksonargo] • link-revisions #67 [jacksonargo] • clix-upload #61 [jacksonargo] • basic-auth-fixup #60 [jacksonargo] • jacksonargo-patch-1 #50 - looks like it's adding data in a way that is no longer used for an old project [jacksonargo] • linters #46 - comment don't care about those linters [jacksonargo] • flyctl #3 - seems fly.io isn't getting used? [jacksonargo] Branches that have never had a PR opened will need someone to look at them and decide if it's a WIP or irrelevant.
• oauth_state [jacksonargo] • feat-discord-oauth [0az] • healthcheck [jacksonargo] • sessions-full [jacksonargo] • sessions-only [jacksonargo] • codecov [jacksonargo] • locksmith [jacksonargo] • improve-download-behavior [0az] • dont-re-upload [jacksonargo] • bootstrap2 [jacksonargo] • fix-mime-database [0az] • client-love [jacksonargo] • bazel [jacksonargo] — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
jacksonargo
The option to automatically delete branches after a PR is merged helps a lot with keeping the number of old branches down. If for some reason there is a desire to keep a branch around after merging, it can either be set as a protected branch (e.g. develop), or it is easy to click the restore branch button on the PR after merging to restore the branch and keep it around for a while longer.
The setting is
Automatically delete head brancheson https://github.com/virtual-vgo/vvgo/settings#merge-button-settingsGoing through https://github.com/virtual-vgo/vvgo/branches/all, all of the branches with the purple
Mergedicon should be safe to delete as a first pass.@0az @jacksonargo @Ranzha I've marked the closed and never merged branches with some names below for who seems to have been working on the branch and could be the most relevant for deciding if it is still needed.
The ones marked
Closedwill require deciding if they will ever be relevant again. I looked through them and there were comments on some of them with things like "not needed".Branches that have never had a PR opened will need someone to look at them and decide if it's a WIP or irrelevant.