eric79
commented
9 years ago Nice work, @AmbientOSX ! I just had that one comment. It would be nice to make sure that the trigger errors aren't due to this change before merging it back, though.
Closed AmbientOSX closed 9 years ago
eric79
commented
9 years ago Nice work, @AmbientOSX ! I just had that one comment. It would be nice to make sure that the trigger errors aren't due to this change before merging it back, though.
AmbientOSX
commented
9 years ago @eric79 That seems to have done the trick :) Thanks for taking a look and helping out!
eric79
commented
9 years ago You bet! Thank for figuring out how to get it working. :wink:
Any new light on those trigger errors?
AmbientOSX
commented
9 years ago Ah, yes those are being addressed with the trigger refactor... I got a bit too meta in my commit comments I think haha
eric79
commented
9 years ago Heh, heh ... okay. Then I give it a :+1: !
@eric79 So the "magic" change is at line 299 in support/client/lib/vwf/view/blockly.js ... things started clicking once a second parameter was added and I made a few other tweaks. I made some other changes and Eric your changes are in here too. Hopefully this all looks good so we can check it against some other replication stuff on the mars-game side of things.