search

virtual-world-framework / vwf

Virtual World Framework
https://virtual.wf
Other
142 stars 53 forks source link

Jplayer marsgame integration #455

Closed n8xm closed 9 years ago

n8xm commented 9 years ago

Incorporated jPlayer into marsgame, in an attempt to fix video problems.

BrettASwift commented 9 years ago

I think someone who is more familiar with the jPlayer driver should do the final review, so I won't give the thumbs up. @eric79 @scottnc27603

scottnc27603 commented 9 years ago

Eric is the only person who has had direct experience with JPlayer, so we'll need to check to see if he has any free time to review.

scottnc27603 commented 9 years ago

The function setWithPrototypeProperties needs to modified. I realize that this was probably already there, but this seems really wrong to me. Every client that connects is going to broadcast the prototype values to all clients. This could potentially overwrite a value on a pre-connected client. I really don't understand what this code is doing at all. Since every client gets a createNode for the audioManager and the videoManager, then I see no reason to do anything other than set local values at this point. I'd be in favor of omitting this all together as the potential side effects seem to far out weigh any gain.

scottnc27603 commented 9 years ago

Not to mention, how is 'node' even defined?

BrettASwift commented 9 years ago

@kadst43 @nmarshak1337 Close and delete now that this is merged into another branch?

kadst43 commented 9 years ago

If we've got everything we need in mg-staging+dev, yes.