search

virtual-world-framework / vwf

Virtual World Framework
https://virtual.wf
Other
142 stars 53 forks source link

Comment out the hammer listeners for touch. Causes a problem in IE11. #457

Closed allisoncorey closed 9 years ago

allisoncorey commented 9 years ago

@kadst43

The hammer.js canvas listeners cause an issue with IE11, preventing the blockly interface from opening. It seems that IE11 registers mouse clicks as touch events as well, which has some bugs in the mars-game-staging branch.

This implementation has been updated in development, along with some default navigation fixes (ie. the middle mouse wheel zoom from the helicam view should be fixed in current development). However, commenting out these hammer listeners is a quick fix since you're not using a touch interface.

The only other problem I noticed while running in IE11 is the rover dialog interface in the bottom left corner of the screen. I am only seeing the yellow action text, not the dialog or sound from the rover. However, functionally, the app seems to be working well.

allisoncorey commented 9 years ago

It is just general touch functionality, so anyone wanting to use a touch screen would need them. I'll let @kadst43 determine their needs for mars-game.

kadst43 commented 9 years ago

I'm not completely sure what's being asked... we don't currently have plans to do touchscreen, though every now and then somebody brings up Chromebooks. Even in that case we wouldn't be using IE 11, though.

That said... it seems like VWF being able to support touch is probably more important than getting Mars Game to run in IE 11 - but that's really a Mark question.

allisoncorey commented 9 years ago

Mark had asked me to look at how to get mars-game running in IE11. This fix would allow mars-game to be demoed in IE11, and is specific to the mars-game-staging branch. This change would not affect the vwf core, as threejs has since been updated, and the touch implementation changed as well. Per Scott's suggestion, adding a check for browser before removing touch functionality would probably be wise, but this was just a quick fix to get it working.

kadst43 commented 9 years ago

Makes sense - and since it's Mars Game specific, I don't think we need a more complex fix.

:+1: