virtual-world-framework / vwf

Virtual World Framework
https://virtual.wf
Other
142 stars 53 forks source link

Hud driver #466

Closed BrettASwift closed 9 years ago

BrettASwift commented 9 years ago

@kadst43 @AmbientOSX @nmarshak1337

I'm doing something out of the ordinary with the draw, elementPreDraw, elementPostDraw, globalPreDraw, and globalPostDraw methods. They're really just carriers for the draw function bodies that contain view code. They should not be called from the application. I went this route as opposed to using a property for readability on the application side.

@eric79 @davideaster Any thoughts on what I'm doing there? Potential problems?

Required by: https://github.com/virtual-world-framework/mars-game/pull/499

davideaster commented 9 years ago

I need to look at this more carefully, but first a few ignorant comments:

kadst43 commented 9 years ago

Nothing jumps out at me as problematic. Ask @eric79 if he's got time to review it... but if not, :+1:

BrettASwift commented 9 years ago

Since this works and only affects Mars-Game, I'm merging it. Any changes/improvements can be handled in later PRs.