search

virtual-world-framework / vwf

Virtual World Framework
https://virtual.wf
Other
142 stars 53 forks source link

Restrict notifyDriverOfPrototypeAndBehaviorProps to 3D nodes #530

Closed BrettASwift closed 8 years ago

BrettASwift commented 8 years ago

@davideaster @kadst43

David, I tested what nodes this portion of the code was hitting by checking for !node || !node.threeObject and all of the child ids it spit out were not important to the driver, so I added the check for node and threeObject. The result was a total load time improvement of 6 seconds on my lap top (~28s down to ~22s). The scene remains intact and the game is playable. I didn't notice any issue in testing. Is there any obvious issue I am missing here or does this do the trick?

davideaster commented 8 years ago

Looks good. Virtually all of the threejs driver functions should have an early exit if the node doesn't map to a three.js node.