virtualabs / btlejack-firmware

Btlejack firmware for BBC Micro:Bit
MIT License
49 stars 27 forks source link

Fix issue where sniffer was unable to follow connections #14

Closed doggkruse closed 3 years ago

doggkruse commented 3 years ago

with hop intervals > 53 due to integer overflow when scheduling hop and set_timer_for_next_anchor interval being uint16_t.

RuhanSA079 commented 3 years ago

Hello, as my firmware were timing out with the hop intervals bigger than 53, mine was 56/57, I think. It seems to begin sniffing, but it times out after a 10-15 seconds. This was enough to me to sniff the traffic I wanted. So all good on my side. Would be nice if we can fix this little bug.

virtualabs commented 3 years ago

Allright, there is definitely an integer overflow that must be fixed here. I missed this point when developing this firmware, shame on me. I'm merging this one, thanks to both of you !