search

virtualabs / radiobit

Micro:Bit Radio framework
144 stars 33 forks source link

Updated micropython and edited modradio for latest MP version #8

Closed hackgnar closed 5 years ago

hackgnar commented 5 years ago

In order to make radiobit work with the latest microbits, I updated the version of MP to the newest upstream. I also had to edit modradio a bit to make it work with the newest version.

I also updated the precompiled radiobit firmware with this code change. Tested and verified working on my end.

Thanks for the great project Damien! I've been having fun with it!

hackgnar commented 5 years ago

@virtualabs I had to make some edits to modradio to make it work with the latest version of MP. Nothing too crazy, just some imports and the rest was simple with vimdiff. The only hacky thing I did was change:

timestamp = uBit.systemTime();`

to

timestamp = 0;

because I wasn't sure what systemTime got changed to in the latest version of MP.

hackgnar commented 5 years ago

I merged the old radiobit modradio headers back into the new version. Good catch!

As for "Does this version work with older microbits". To be honest, I have no idea. If I had one, I would have used that instead of updating micropython for radiobit 😁.

We could always revert the patch if it causes issues for older radiobits.

virtualabs commented 5 years ago

Well, we'll see. PR accepted and now merged. And yep, it is always possible to revert so no big deal.

Thank you again for your contribution !