virtualcell / vcell

Virtual Cell Framework
http://vcell.org/
Other
66 stars 20 forks source link

Execution of example simulation has multiple issues #112

Closed jonrkarr closed 2 years ago

jonrkarr commented 3 years ago

VCell now runs successfully in runBioSimulations with 5 example simulation runs. All runs terminate successfully. However, the results contain NaN for outputs of failed simulations (Euler with step size too high).

Example:

SED-ML file simulation.sedml in sbml-core/Vilar-PNAS-2002-minimal-circardian-clock.omex

Because the simulation failed, we would prefer to clearly communicate this to the user by labeled that simulation as FAILED.

Deeper investigation revealed multiple issues:

jonrkarr commented 3 years ago

I'm also going to remove this COMBINE archive from the examples to reduce potential confusion as people would likely assume these are viable simulations.

moraru commented 2 years ago

Fixed