Faithfully process names for SED-ML outputs (avoid inventing names for SED-ML elements when names aren't set)

jonrkarr commented 3 years ago

The hidden screenshot at https://github.com/virtualcell/vcell/issues/81#issuecomment-923100525 shows a sedmlName attribute. However, the name for this SED-ML report is not set. Only the id attribute for this report is set.

It looks like VCell is creating names when names aren't set. When names aren't set, VCell appears to be setting names equal to ids. This conflates the separate purposes of ids and names.

If the name isn't set, it should ideally stay this way (i.e., null/None), at least when outputs are generated, such as at vcell-cli-utils/vcell_cli_utils/cli.py#L55.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

jonrkarr commented 2 years ago

I think this has been resolved

moraru commented 2 years ago

Fixed

virtualcell / vcell

Faithfully process names for SED-ML outputs (avoid inventing names for SED-ML elements when names aren't set) #94