search

virtuald / pyhcl

HCL is a configuration language. pyhcl is a python parser for it.
Mozilla Public License 2.0
335 stars 60 forks source link

Unpin ply version allowing versions until next major release. #48

Closed moisesguimaraes closed 5 years ago

moisesguimaraes commented 5 years ago

According to discussion in https://github.com/virtuald/pyhcl/pull/38 I'm opening this PR to see if we can move on in the effort to get hvac into OpenStack.

virtuald commented 5 years ago

According to https://travis-ci.org/virtuald/pyhcl/builds/499686034 it appears that 3.8 thru 3.11 work fine. Why should the range be opened up further? PLY doesn't honor semver and has broken compat in the past (though it appears to be in maintenance mode now).

moisesguimaraes commented 5 years ago

We need it opened up to comply to OpenStack guidelines, would you like me to open an issue with ply? I think @dabeaz would be willing to honor semver.

virtuald commented 5 years ago

What are their guidelines? I'm not familiar with them.

moisesguimaraes commented 5 years ago

You can find OpenStack dependency management guidelines here:

https://docs.openstack.org/project-team-guide/dependency-management.html

To my understanding, the global-requirements.txt lists the required packages to run OpenStack services, and the upper-constraints.txt lists the latest version of the required packages and is automatically updated by a bot which would in the future update the version of ply to higher than 3.11 when they release a new version and it would be tested on the CI. But since it is pinpointed to a specific version on your requirements.txt, it would not be "updatable".

I might have missed something or didn't explained the best way cause this is one of my first works adding a new dependency. But I think @prometheanfire could provide more details if needed.

And thanks for putting some time on this, we would really like to switch from https requests to hvac when talking to HashiCorp Vault.

prometheanfire commented 5 years ago

that's the basics of it. not much relies on ply right now, but those packages that do would be pinned to the same version pyhcl pins to.

virtuald commented 5 years ago

Will fix in master shortly.