virtualeconomy / v-systems

V Systems Reference Full Node
Other
115 stars 45 forks source link

Create Dockerfile #217

Closed faddat closed 4 years ago

faddat commented 4 years ago

beginnings of a Coinbase Rosetta compliant Dockerfile, which covers the "build node from source and run it" part.

PR Details

This is a dockerfile that can easily be used to run V Systems nodes in the known-good configuration recommended by our team. It will only produce a known-good config image after #214 has been merged to add the changes to network and wallet configuration. #214 is not successful at suppressing #208 .

Description

Adds a build-anywhere dockerfile built to these specifications:

https://www.rosetta-api.org/docs/node_deployment.html#good-example

Related Issue

216

215

210

208

211

Motivation and Context

Should choose a single good way to ship to the system software. After we develop this single good way to ship the V System software, we should document using it. This way, there will be no more reliability issues, and we will know how the V Systems software is being run by the users.

This Dockerfile is an example of one known good configuration for V systems node.

How Has This Been Tested

I built this with GitLab CI, and I tested it on my laptop and one of my bare metal servers and Hetzner.

Types of changes

Checklist

Afterr we have had a conversation about the best way to deploy VSYS, I will update our default documentation to reflect it.

ncying commented 4 years ago

https://github.com/virtualeconomy/v-systems/blob/77e9f877c56fe67ed702c6a4e1bb63e2c957f9ee/build.sbt#L84-L103 is for docker build in the integral test. But we will not deliver docker to users since they will need different settings to run the node. If we still pick out the conf file, it should be the same to use the java one.

I think it is better to add some documentation about how to build/use the docker for users in Wiki rather than put some code in this repo.

faddat commented 4 years ago

OK, I figure it's best to close this PR, then.

Do we plan to support Rosetta?