virtualeconomy / v-systems

V Systems Reference Full Node
Other
115 stars 45 forks source link

Contract/vswap prevent same token #286

Closed twwu123 closed 3 years ago

twwu123 commented 3 years ago

PR Details

Prevent users from depositing into V Swap contract if the input tokens are the same.

Motivation and Context

There would be some strange behaviour if users are allowed to swap between the same token, or if the liquidity token is the same as the swappable tokens.

Types of changes

Checklist

codecov-commenter commented 3 years ago

Codecov Report

Merging #286 (3fd9467) into exchange (17501fa) will increase coverage by 12.96%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           exchange     #286       +/-   ##
=============================================
+ Coverage     59.70%   72.67%   +12.96%     
=============================================
  Files           207      207               
  Lines          7326     7468      +142     
  Branches        270      256       -14     
=============================================
+ Hits           4374     5427     +1053     
+ Misses         2952     2041      -911     
Impacted Files Coverage Δ
...scala/vsys/blockchain/contract/ContractVSwap.scala 100.00% <100.00%> (ø)
src/main/scala/vsys/Application.scala 0.00% <0.00%> (ø)
...cala/vsys/api/http/contract/ContractApiRoute.scala 0.00% <0.00%> (ø)
...main/scala/vsys/blockchain/contract/Contract.scala 90.22% <0.00%> (+4.34%) :arrow_up:
...ala/vsys/blockchain/contract/ContractTokenV2.scala 100.00% <0.00%> (+100.00%) :arrow_up:
...ala/vsys/blockchain/contract/ContractVEscrow.scala 100.00% <0.00%> (+100.00%) :arrow_up:
...ala/vsys/blockchain/contract/ContractVOption.scala 100.00% <0.00%> (+100.00%) :arrow_up:
...vsys/blockchain/contract/ContractVStableSwap.scala 100.00% <0.00%> (+100.00%) :arrow_up:
...ys/blockchain/contract/ContractNonFungibleV2.scala 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17501fa...3fd9467. Read the comment docs.