search

virtualmin / virtualmin-nginx

Virtualmin plugin to allow use of nginx web server for virtual domain hosting
GNU General Public License v3.0
36 stars 13 forks source link

Questioning default attribute of new listen directive in module version 2.22 #20

Open neosonic2 opened 3 years ago

neosonic2 commented 3 years ago

Hello,

We are using the neW Nginx module version 2.22 in our Virtualmin Professional 6.16 setup and are enjoying the features added to support HTTP/2, correct HTTP 301 redirects, and excluding IP addresses from listen directives. However, it is this last feature that I am concerned about.

When this option is activated, it creates HTTPS listen directives that look like this: listen 443 default ssl http2;

Will the default attribute in this directive create conflicts if we have multiple Nginx virtual hosts? I thought it was better to specify one default server? Is there a way to tell Virtualmin not to include the default attribute when creating a new virtual server?

Thanks for any insight provided.

jcameron commented 3 years ago

The default attribute is only used when a domain has it's own private IP address - so there shouldn't be any conflict with other domains.

neosonic2 commented 3 years ago

Our server running Virtualmin only has 1 public IP address (and 1 private LAN-only IP address). Does Virtualmin perform any validation when determining whether to add the default attribute to an Nginx virtual host configuration?

jcameron commented 3 years ago

Virtualmin should only use default for the first SSL website on an IP. Subsequent ones won't get it.

Are you seeing any specific problems due to this directive?