Password recovery pop-up box doesnt appear for Usermin (20000) due to javascript issue.

[abclution]

Hi again everyone. This plugin works fine when resetting from the Webmin (10000) area, but there is a problem with this module in the Usermin area (20000)

When clicking the button (In usermin login), the reset floating window never appears. Chrome flashes momentarily a javascript issue.

Invalid or unexpected token

The problem seems to lie with the /etc/usermin/custom-lang file, it seems to be that the

onclick='javascript:event.target.port=10000' (required for the usermin page to talk to the webmin module) the syntax along with the window.open is not quite right.

I tried to figure it out... 3+ hours so I could submit a bugfix for it, but I just couldn't figure it out.

Sorry.

[jcameron]

@iliarostovtsev possible theme issue?

[iliajie]

I think, we could call it a theme bug. Fixed now - https://github.com/authentic-theme/authentic-theme/commit/c05290aa6757766e977e33fa093e4df96f0282a2. I will make a release tomorrow. Want to fix a few small issues. All is nearly ready for 19.60 release.

Jamie, do you know why Authentic theme library is not loaded with virtualmin-password-recovery module?

[jcameron]

Could it be because the password recovery CGIs are called before logging in?

[abclution]

@iliarostovtsev I tested this and it seems to work now. It opens in a new tab instead of a floating window. This is ok.

Also, low priority (functionality works!) and more of a suggestion, I think the password recovery page should match the look of the theme (I know, a million moving parts for translation strings etc etc)

Something like this:

There is a stark contrast in the password recovery form when it opens up in comparison to the beauty of the rest of the virtualmin theme windows.