search

virtualsatellite / VirtualSatellite4-Core

Virtual Satellite Core - Baseline Framework and IDE Tools
Eclipse Public License 2.0
30 stars 18 forks source link

Added new issue template for hot fix releases #1215

Closed PhilMFischer closed 1 month ago

PhilMFischer commented 1 month ago
fmbouga commented 1 month ago

Hello Philipp,

I just wait when the runs are completed before finishing the review. I am throwing a look on the file changes.

Kind regards,

Frank

Von: Philipp M. Fischer @.> Gesendet: Donnerstag, 17. Oktober 2024 09:57 An: virtualsatellite/VirtualSatellite4-Core @.> Cc: Mbouga, Frank Eric @.>; Review requested @.> Betreff: Re: [virtualsatellite/VirtualSatellite4-Core] Added new issue template for hot fix releases (PR #1215)

@PhilMFischer https://github.com/PhilMFischer requested your review on: #1215 https://github.com/virtualsatellite/VirtualSatellite4-Core/pull/1215 Added new issue template for hot fix releases.

— Reply to this email directly, view it on GitHub https://github.com/virtualsatellite/VirtualSatellite4-Core/pull/1215#event-14694590524 , or unsubscribe https://github.com/notifications/unsubscribe-auth/BL6UXFVLGID7LKAAI3RN7M3Z35UTJAVCNFSM6AAAAABQDD4WWWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGY4TINJZGA2TENA . You are receiving this because your review was requested.Message ID: @.***>

fmbouga commented 1 month ago

Hi @PhilMFischer. I saw that the Build and Test for Spotbugs,Surefire and Checkstyle failed. Is it an issue to consider during our review or not obviously.

PhilMFischer commented 1 month ago

Hi @PhilMFischer. I saw that the Build and Test for Spotbugs,Surefire and Checkstyle failed. Is it an issue to consider during our review or not obviously.

@fmbouga For sure the builds should run, otherwise we cannot merge them back into one of our main development lines. Still we allow reviews before everything is perfectly running.

This means it it is finally your decision. In this case where just an issue template has been changed things should be fine. In case it was a major refactoring of our code, it is probably better to have really everything running before reviewing.

Thank you for the explanation