Mailing list sign-up through cloudflare worker

virtualscienceforum / automation

Scripts for running the VSF

BSD 2-Clause "Simplified" License

0 stars 1 forks source link

Mailing list sign-up through cloudflare worker #6

Closed everthemore closed 4 years ago

everthemore commented 4 years ago

Still WIP, don't merge yet

akhmerov commented 4 years ago

Still to do:

[x] use a better sign-up email (optionally using mailgun templates as opposed to the worker itself).
[x] Check that we handle resubscriptions properly
[x] limit CORS to virtualscienceforum.org
[x] sign up the user to the correct mailing lists from the request
[x] clean up and review

everthemore commented 4 years ago

Have a look at this @akhmerov

akhmerov commented 4 years ago

~~I propose to use the following plaintext email:~~

Dear %recipient_name%,

You successfully subscribed to the Virtual Science Forum mailing lists that you selected.
If you change your mind, use the unsubscribe link provided in the mailing list emails.

Regards,
The VSF team

(%recipient_name% will be substituted by mailgun if provided).

EDIT: I should have read on. The current implementation LGTM.

akhmerov commented 4 years ago

For resubscriptions I think we should set the "upsert" flag to "yes", see here.

The rest LGTM (except for 418—that's not what VSF stands for).

everthemore commented 4 years ago

@akhmerov tiny bugfix in the response. Other than that, let's merge and give it a test (especially the CORS and welcome email)