Mark `sideEffects` - Githubissues

virtualstate / navigation

Native JavaScript navigation [web api] implementation

MIT License

77 stars 5 forks source link

Mark `sideEffects` #28

Closed TomokiMiyauci closed 5 months ago

TomokiMiyauci commented 5 months ago

Prerequisites

[X] I have written a descriptive issue title
[X] I have searched existing issues to ensure it has not already been reported

Version (i.e. v2.x.x)

v1.0.1-alpha.95

Node.js version (i.e. 18.x, or N/A)

No response

Operating system

None

Operating system version (i.e. 20.04, 11.3, 10, or N/A)

No response

Description

If sideEffects in package.json is false, the bundler will remove the following:

import "@virtualstate/navigation/polyfill";.

The sideEffects field must be removed or the sideEffects file must be enumerated.

Steps to Reproduce

bundle it

Expected Behavior

Reference:

For example, urlpattern-polyfill has no sideEffects field.

fabiancook commented 5 months ago

Makes sense!

Have now dropped this. Originally this project wasn't a polyfill directly and had to be imported.

Thanks for reporting this, should be resolved with alpha-201