virtualvivek / react-windows-ui

Build Windows native look & feel apps using ReactJS. Provides a set of accessible, reusable and composable react components that make it super easy to create websites and apps.
https://virtualvivek.github.io/react-windows-ui/
MIT License
537 stars 44 forks source link

CommandBar #15

Closed zivlakmilos closed 2 years ago

zivlakmilos commented 2 years ago

I think that having CommandBar like in Fluent library will be great addition to this set of components.

https://developer.microsoft.com/en-us/fluentui#/controls/web/commandbar

I really like this library, but I found that I miss CommandBar.

virtualvivek commented 2 years ago

Hi @zivlakmilos ,

Thanks for supporting the lib actually it has a commandBar but i forget to add the docs about it Here it is : https://virtualvivek.github.io/react-windows-ui/#/CommandBarLayout

If you get something this this above then i will sure add docs and usage tommorow or if you need some improvement you can just mention here :)

zivlakmilos commented 2 years ago

That's great. Thanks for great work. :)

virtualvivek commented 2 years ago

I have also checked the link you shared from microsoft's official docs and i find out that i need to add some more customization to the existing CommandBar component.

thanks for opening the issue ,I find it usefull :)

zivlakmilos commented 2 years ago

I found problem with CommandBar component. It's "floating" above content. So content goes behind it and it's not visible. I don't know is that desired behavior. You can see that in Your example, where h1 tag is not visible.

virtualvivek commented 2 years ago

Hi @zivlakmilos ,

Yup the CommandBar default behaviour is floating before but now i realized after seeing ms official CommandBar that our's is not so much productive for now so i am customizing bit more along with its docs.

:)

virtualvivek commented 2 years ago

Hi @zivlakmilos ,

I have updated CommandBar component along with its docs see https://virtualvivek.github.io/react-windows-ui/#/commandbar can you see and suggest me to publish the updates or requies further changes.

zivlakmilos commented 2 years ago

Looks good to me. :)