search

viruschidai / validate-vat-ts

A library for validating VAT number
32 stars 13 forks source link

Update for recent VIES changes #36

Closed ParallelUniv3rse closed 2 years ago

ParallelUniv3rse commented 2 years ago

Tests are still failing due to the VIES test service not responding with corresponding errors for the test cases. I'll update when I get a response back for my email, where I've asked if this is intended

Would love any input on the new semver version. Not sure if to mark this as PATCH or MINOR due to the fact that now the service responds with an empty vatNumber when it's not valid. That seems only semi-compatible with the previous version.

ParallelUniv3rse commented 2 years ago

Follow-up fix for the failing jest tests in https://github.com/viruschidai/validate-vat-ts/pull/41