search

virusseq / portal-ui

Canadian VirusSeq Data Portal
https://virusseq-dataportal.ca/
GNU Affero General Public License v3.0
8 stars 8 forks source link

Conflict between react@17.0.2 and react@"^16.12.0 dependencies on npm install #358

Closed pvanheus closed 1 year ago

pvanheus commented 1 year ago

When I run npm install on the latest commit (ccbe822010b82c5f0a319108fabc6079db99c1ad), I get a dependency conflict:

$ npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @arranger/components@2.19.2
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR!   peer react@"^16.9.0 || ^17" from react-datepicker@3.8.0
npm ERR!   node_modules/@arranger/components/node_modules/react-datepicker
npm ERR!     react-datepicker@"^3.8.0" from @arranger/components@2.19.2
npm ERR!     node_modules/@arranger/components
npm ERR!       @arranger/components@"^2.19.2" from the root project
npm ERR!   25 more (react-popper, @emotion/react, @emotion/styled, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.12.0" from @arranger/components@2.19.2
npm ERR! node_modules/@arranger/components
npm ERR!   @arranger/components@"^2.19.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@16.14.0
npm ERR! node_modules/react
npm ERR!   peer react@"^16.12.0" from @arranger/components@2.19.2
npm ERR!   node_modules/@arranger/components
npm ERR!     @arranger/components@"^2.19.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/pvh/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pvh/.npm/_logs/2023-01-22T09_09_58_406Z-debug-0.log

This is with npm 8.19.3, node 18.3.0. Forcing install with --legacy-peer-deps results in an install that passes npm run test.

justincorrigible commented 1 year ago

Blame Arranger for this 🤦

Thank you for bringing this to our attention, @pvanheus

justincorrigible commented 1 year ago

This issue should be resolved now that Arranger3 has been published along with an updated version of the Portal app. Closing ticket as fixed