search

visa / visa-chart-components

Visa Chart Components (VCC) is an accessibility focused, framework agnostic set of data experience design systems components for the web. VCC attempts to provide a toolset to enable developers to build equal data experiences for everyone, everywhere.
https://visa.github.io/visa-chart-components/
MIT License
151 stars 28 forks source link

Alluvial Chart Frequency Values #51

Closed brichard1638 closed 2 years ago

brichard1638 commented 2 years ago

The frequency values in the final Alluvial html file are missing. This issue can be replicated by viewing the Alluvial chart provided by the package's code sample.

chris-demartini commented 2 years ago

Hi @brichard1638 - I took a quick look into this with the provided demo in visachartR and do see the frequency values are present on the links in the Alluvial Diagram, maybe you can provide a screenshot of a simple example and where you see the data from this field is missing? Thanks!

brichard1638 commented 2 years ago

Chris:::

Thank you for your response!

I have attached a sample of the version of the Alluvial diagram that I see when I use the exact sample code provided in the visachartR example.

Warm regards,

Brice Richard

From: Chris DeMartini @.> Sent: Thursday, February 10, 2022 11:26 AM To: visa/visa-chart-components @.> Cc: brichard1638 @.>; Mention @.> Subject: Re: [visa/visa-chart-components] Alluvial Chart Frequency Values (Issue #51)

Hi @brichard1638https://github.com/brichard1638 - I took a quick look into this with the provided demo in visachartR and do see the frequency values are present on the links in the Alluvial Diagram, maybe you can provide a screenshot of a simple example and where you see the data from this field is missing? Thanks!

— Reply to this email directly, view it on GitHubhttps://github.com/visa/visa-chart-components/issues/51#issuecomment-1035124764, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASLI5UL53OOFAFRWH264Y2TU2PRJ3ANCNFSM5N5UHYSQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

chris-demartini commented 2 years ago

This was a great find @brichard1638 , we have reproduced it and will push a fix for it in the next version. Thank you!

brichard1638 commented 2 years ago

Chris:::

I am glad my recommendations were accepted.

Thank you for the work you do in maintaining an extraordinary contribution to R with visachartR.

Warm regards,

Brice Richard Data Scientist Washington, DC, USA

From: Chris DeMartini @.> Sent: Tuesday, March 8, 2022 12:20 AM To: visa/visa-chart-components @.> Cc: brichard1638 @.>; Mention @.> Subject: Re: [visa/visa-chart-components] Alluvial Chart Frequency Values (Issue #51)

This was a great find @brichard1638https://github.com/brichard1638 , we have reproduced it and will push a fix for it in the next version. Thank you!

— Reply to this email directly, view it on GitHubhttps://github.com/visa/visa-chart-components/issues/51#issuecomment-1061417207, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASLI5UJ34VKAYOKCIMPN2ULU63PTHANCNFSM5N5UHYSQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

fkohrt commented 2 years ago

@chris-demartini I believe this is the same issue I reported at #50, so consider that solved as well.

brichard1638 commented 2 years ago

Florian:::

Thank you for the update!

I look forward to the next updated version of visachartR!

Once released, I will test the issues I initially submitted and provide my feedback, in the hopes that it will confirm and enhance this remarkable package.

Warmest regards,

Brice Richard Data Scientist Washington, DC USA

From: Florian Kohrt @.> Sent: Saturday, March 12, 2022 7:25 AM To: visa/visa-chart-components @.> Cc: brichard1638 @.>; Mention @.> Subject: Re: [visa/visa-chart-components] Alluvial Chart Frequency Values (Issue #51)

I believe this is the same issue I reported at #50https://github.com/visa/visa-chart-components/issues/50#issuecomment-1036231467, so consider that solved as well.

— Reply to this email directly, view it on GitHubhttps://github.com/visa/visa-chart-components/issues/51#issuecomment-1065874530, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASLI5UMV2R5SQUNNI6PQC4LU7SEK5ANCNFSM5N5UHYSQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were mentioned.Message ID: @.***>

chris-demartini commented 2 years ago

Good point @fkohrt, @brichard1638 can you please confirm whether the issue Florian calls out is the same one you were referring to? We fixed the issue with our data table that Florian described, so if there is something else here we may not have addressed your concern yet. If there is something else here, please be sure to provide enough detail in your feedback so that we can try to reproduce this on our side. Thanks!

chris-demartini commented 2 years ago

released in 6.1.0, closing