search

viscenter / layered-viewer

(Archive Repository) Registered image viewer based on OpenSeadragon
https://gitlab.com/educelab/vislayers
Other
6 stars 1 forks source link

Potential v1.1 #45

Closed stephenrparsons closed 8 years ago

stephenrparsons commented 8 years ago

This fixes some small interface bugs and adds full copyright/license info.

csparker247 commented 8 years ago

Mostly looks fine. I think some of the CSS might have gotten messed up with the newer versions of the Polymer libraries (drop shadows are weird on the help button and layer bar hiding button, forward and backward page icons are weirdly small). As long as we don't update the bower components on the server, this should be fine. Just make sure you test it.

stephenrparsons commented 8 years ago

That's what I had in mind as well, but it would obviously better if we didn't have to do that. I'll take a look and see if I can get it to work with all updated packages, and then redo the pull request. Would it be better for me to make the PR on develop, and then we can make a new release from this repo?

Also (barely related), I talked to some OSD people and multi-image does not yet have clipping we need, so we are doing this the best way. I think I am going to try to contribute it to OSD as a summer project, but that will be a while.

csparker247 commented 8 years ago

Yeah, PR onto develop.