visciang / telegram

Telegram library for the Elixir language
MIT License
204 stars 27 forks source link

Move tesla adapter to config #128

Closed prtngn closed 2 years ago

prtngn commented 2 years ago

Delete tesla adapter config from client.ex for the opportunity to config from config files.

visciang commented 2 years ago

Hi @prtngn! The idea of making the HTTP library pluggable leveraging the Tesla abstraction is not bad. It gives the possibility to stick to the same HTTP library you decided to use, not only at app level but also down to your deps (as much as they all are open to this kind of configurability).

But there are some considerations we should pay attention to:

I think you understand it needs a bit of investigation before jumping to a conclusion. I'll think about it. Feel free to discuss here if you want.

Thank you

prtngn commented 2 years ago

Thanks for you answer. And big thanks for this library.

So, you right ) I only learning elixir ) I faced a problem with self-signed certificate+proxy and that's why I need to config Tesla adapter. I think it is a good idea to stay default Tesla config in telegram module and give opportunity to config Tesla adapter in program config.

But I don't understand how I can do it ))