remove token from logger metadata

visciang / telegram

Telegram library for the Elixir language

MIT License

204 stars 27 forks source link

remove token from logger metadata #130

Closed ninedraft closed 2 years ago

ninedraft commented 2 years ago

Thank you very much for the handy library!

The telegram token is secret information, so I think it would be better to remove it from the logger metadata.

coveralls commented 2 years ago

Coverage remained the same at 100.0% when pulling 769426815e862f0a21c14e1262ba26b5e115d180 on ninedraft:remove-token-logging into 3fe996d7feba4335ac9b21190cc3862f5d3f681f on visciang:master.

visciang commented 2 years ago

@ninedraft you are right, make sense. I've cleaned up also some ref to the token in the README and test config (https://github.com/visciang/telegram/pull/130/commits/8fd2c88c42afd66b15b465cd6383d661c376f840).

Thank you!