Add handle_info/4 callback to Telegram.ChatBot behavior

visciang / telegram

Telegram library for the Elixir language

MIT License

204 stars 27 forks source link

Add handle_info/4 callback to Telegram.ChatBot behavior #157

Closed Overbryd closed 1 year ago

Overbryd commented 1 year ago

This is helpful to implement bots that act on scheduled events (using Process.send and Process.send_after)

visciang commented 1 year ago

That's great @Overbryd !

May I ask you to extend the @module_doc in lib/chat_bot.ex with handle_info callback?

One thing we miss is to extend / add a test to cover the functionality.

The callback should be optional.

We need also to think and document how a client can/should address the server (internally now we leverage Telegram.Bot.ChatBot.Chat.Registry.via(token, chat_id) etc) when sending an "info" message.

Ping me if you need help or want to discuss something

Thank you

coveralls commented 1 year ago

coverage: 100.0%. remained the same when pulling 15ade6b889d0b9dc287e45233b241df4ad968c44 on Overbryd:feat/handle-info into 89efeaddf3ed27b315e8d08b955c47e7539d2f26 on visciang:master.

visciang commented 1 year ago

I've just added the test / docs / ... Thank you for your contribution!

Resolve #154