Add ability to make states public

visdesignlab / Sanguine

Sanguine is a web-based visualization tool built by the VDL and ARUP that visualizes hospital blood usage and associated patient/surgery attributes. It is designed to be used by clinicians, researchers, and administrators to understand blood usage patterns, identify opportunities to improve patient outcomes, and reduce transfusion expenditures.

BSD 3-Clause "New" or "Revised" License

7 stars 0 forks source link

Add ability to make states public #157

Closed JackWilb closed 3 years ago

JackWilb commented 3 years ago

Closes #149

Waiting on some frontend changes here and on some testing

JackWilb commented 3 years ago

[x] Need to add Switch from material ui to creation screen with "public" label
[x] Need to update requests for PUT and POST state to use new params

haihan-lin commented 3 years ago

[x] Made the changes.
[x] fixed the alerts (I think?). There should be success/failure alert at the bottom of the interface upon clicking confirm.
[x] The button also disables if there is no input for state name.

JackWilb commented 3 years ago

Things I noticed:

no timeout for snack bar (can we add one so it doesn't just persist until closed?
making state cleared the states list (on internal server error, works on success)

My TODOs:

[x] Test that public states are available to all
[x] Test that private states are not available to all

haihan-lin commented 3 years ago

the snacker timeout is a minute. maybe 5 seconds instead?