search

visdesignlab / Sanguine

Sanguine is a web-based visualization tool built by the VDL and ARUP that visualizes hospital blood usage and associated patient/surgery attributes. It is designed to be used by clinicians, researchers, and administrators to understand blood usage patterns, identify opportunities to improve patient outcomes, and reduce transfusion expenditures.
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

share through URL is not properly loading #169

Closed haihan-lin closed 3 years ago

haihan-lin commented 3 years ago

Upon opening a new tab with the URL does not load the state. Talk to Kiran perhaps?

haihan-lin commented 3 years ago

@JackWilb I have a fix for this, however, we might want to reconsider this feature: when the URL gets insanely long (which it does, when you select many patients), everything breaks. Chrome wouldn't read the URL and load properly

Potential way to get around this:

  1. loading url with some state name and then make an API call to the state, instead of having the state json obj in the url itself.
  2. just delete this feature
JackWilb commented 3 years ago

I'm personally of the opinion that we should just remove the sharing by url, instead favoring the state system that we're setting up (especially since we're adding so many new features to it)

haihan-lin commented 3 years ago

ok the removal is already pushed to the PR.