visdesignlab / Sanguine

Sanguine is a web-based visualization tool built by the VDL and ARUP that visualizes hospital blood usage and associated patient/surgery attributes. It is designed to be used by clinicians, researchers, and administrators to understand blood usage patterns, identify opportunities to improve patient outcomes, and reduce transfusion expenditures.
BSD 3-Clause "New" or "Revised" License
7 stars 0 forks source link

Refactor all typescript types for charts, standardize axes and outcomes across charts #295

Closed JackWilb closed 1 day ago

JackWilb commented 1 day ago

Does this PR close any open issues?

Closes #164 Closes #284

Give a longer description of what this PR addresses and why it's needed

This refactoring fully overhauls the types for the charts, and makes the charts use a shared vernacular (x axis, y axis, and outcome) to refer to the variables that are to be visualized. Each chart comes with x and y values (some are fixed, like x = "cost" for the cost bar charts), and heat maps and cost charts have outcomes that can be visualized.

One side effect of this change is that we're now less reliant on an index values to grab the requisite data. This is more robust, but there is still some work to be done here.

Provide pictures/videos of the behavior before and after these changes (optional)

Generally the same, some options in the chart add bar have changed.

Are there any additional TODOs before this PR is ready to go?

No