search

visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
53 stars 7 forks source link

feat: 🎸 Filter intersections UI update #166

Closed JakeWags closed 1 year ago

JakeWags commented 1 year ago

Does this PR close any open issues?

Closes #119

Give a longer description of what this PR addresses and why it's needed

Addresses comments by @alexsb on filter intersections:

Also, we probably need a bit more instructions for the Less Than / More Than. We should probably say "Filter by Degree" as a title, and add a question mark icon and provide help text: "Show only intersections that have a degree higher than the "More Than" and lower than the "Less Than" value.

Uses Min Degree and Max Degree rather than More Than and Less Than. I feel like this verbiage is more verbose and understandable without tool-tips.

The tool-tip for the min and max degrees was relocated to the new sub-header Filter By Degree, which says "Show only intersections that have a degree higher than the "Min Degree" and lower than the "Max Degree" value"

Also, the font size for the entire sidebar was reduced to 0.9rem and the font size for headers was changed to 0.95rem. Hide Empty Intersections is set to 0.8rem to avoid a line-break.

Provide pictures/videos of the behavior before and after these changes (optional)

image

netlify[bot] commented 1 year ago

Deploy Preview for upset2 ready!

Name Link
Latest commit a439de5aeb53125fc48a7e43e2f13d18ddd45425
Latest deploy log https://app.netlify.com/sites/upset2/deploys/6451453958ec150008afb08f
Deploy Preview https://deploy-preview-166--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.