visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
53 stars 7 forks source link

feat: 🎸 Accessible data-table #205

Closed JakeWags closed 1 year ago

JakeWags commented 1 year ago

Does this PR close any open issues?

Closes #200

Give a longer description of what this PR addresses and why it's needed

This adds the data table for the subset data. This table uses MUI DataGrid (MIT License). The table is keyboard navigable and I tested it with the Mac VoiceOver and it seems usable (although I have VERY limited experience with screen readers).

Note that this component is within the app package and the button to open the data table is easily accessible via the toolbar.

Provide pictures/videos of the behavior before and after these changes (optional)

image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 1 year ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 1e3374f7723cf7e07da5858d02900a3295997480
Latest deploy log https://app.netlify.com/sites/upset2/deploys/64a58d77d424420008de84a4
Deploy Preview https://deploy-preview-205--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.