search

visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Consistent element naming scheme for processed and accessible data #280

Closed JakeWags closed 8 months ago

JakeWags commented 8 months ago

Does this PR close any open issues?

Closes #279

Give a longer description of what this PR addresses and why it's needed

This PR makes the naming scheme more consistent for elementName in data state exports.

Before: see #279

After:

{
      "Subset_School_Evil Male": {
          "elementName": "School, Evil, and Male",
          "type": "Subset",
          ...
      }
}

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 8 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 40b4675cd6afb4b6d42d8873e575a867b4404e5d
Latest deploy log https://app.netlify.com/sites/upset2/deploys/657b883eebcced00082418e4
Deploy Preview https://deploy-preview-280--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.